srielau commented on code in PR #48546:
URL: https://github.com/apache/spark/pull/48546#discussion_r1806803078
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##########
@@ -1154,9 +1154,33 @@ public static StringSearch getStringSearch(
* Returns the collation ID for the given collation name.
*/
public static int collationNameToId(String collationName) throws
SparkException {
+ // If collation name is given as a fully qualified name, extract the
actual collation name as
+ // the last part of the [catalog].[schema].[collation_name] name.
+ long numDots = collationName.chars().filter(ch -> ch == '.').count();
Review Comment:
Don't we have standard functions for this. Also who would use this method in
this way?
If teh collation was parsed it should be passed as a Seq of identifiers (or
something like it). It should NOT have been assembled as a qualified string.
At this point we can also just "eaT" teh qualifiers after chjecking that
they are correct.
only once we have user defined collatiosn will we need to actually deal with
non SYSTEM.BUILTIN qualfiers.
That day may not come for years.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
