HeartSaVioR commented on code in PR #48553:
URL: https://github.com/apache/spark/pull/48553#discussion_r1808117289
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ExpiredTimerInfoImpl.scala:
##########
@@ -16,21 +16,15 @@
*/
package org.apache.spark.sql.execution.streaming
-import org.apache.spark.sql.streaming.{ExpiredTimerInfo, TimeMode}
+import org.apache.spark.sql.streaming.ExpiredTimerInfo
/**
* Class that provides a concrete implementation that can be used to provide
access to expired
* timer's expiry time. These values are only relevant if the ExpiredTimerInfo
* is valid.
- * @param isValid - boolean to check if the provided ExpiredTimerInfo is valid
* @param expiryTimeInMsOpt - option to expired timer's expiry time as
milliseconds in epoch time
*/
-class ExpiredTimerInfoImpl(
- isValid: Boolean,
- expiryTimeInMsOpt: Option[Long] = None,
- timeMode: TimeMode = TimeMode.None()) extends ExpiredTimerInfo {
Review Comment:
Is it a side effect? It's obvious to remove isValid, but timeMode does not
seem to be obvious.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
