magpierre commented on code in PR #81:
URL: https://github.com/apache/spark-connect-go/pull/81#discussion_r1808547073
##########
spark/sql/functions/generated.go:
##########
@@ -3073,9 +3073,14 @@ func BitmapOrAgg(col column.Column) column.Column {
return
column.NewColumn(column.NewUnresolvedFunctionWithColumns("bitmap_or_agg", col))
}
-// Ignore UDF: call_udf: (udfName: str, *cols: 'ColumnOrName') ->
pyspark.sql.connect.column.Column
+// Ignore UDF: call_udf: (udfName: str, *cols: 'ColumnOrName') ->
sql.connect.column.Column
-// Ignore UDT: unwrap_udt: (col: 'ColumnOrName') ->
pyspark.sql.connect.column.Column
+// UnwrapUdt: (col: 'ColumnOrName') -> sql.connect.column.Column
+//
+// Unwraps the UDT so you can work with the internal data structure embedded
in the type
+func UnwrapUdt(col column.Column) column.Column {
+ return
column.NewColumn(column.NewUnresolvedFunctionWithColumns("unwrap_udt", col))
+}
Review Comment:
I recommend we reject this PR and rerun and the generation script instead. I
have looked at gen.py and I don't see a reason why this would not be generated.
It is a valid and important function even though we might not have UDT support
yet since the data source may very well use UDT's and the function returns the
internal data structure of the type rather than the type making it usable from
regular spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
