Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/688#discussion_r12502020
  
    --- Diff: project/SparkBuild.scala ---
    @@ -573,7 +573,14 @@ object SparkBuild extends Build {
         name := "spark-assembly",
         assembleDeps in Compile <<= (packageProjects.map(packageBin in Compile 
in _) ++ Seq(packageDependency in Compile)).dependOn,
         jarName in assembly <<= version map { v => "spark-assembly-" + v + 
"-hadoop" + hadoopVersion + ".jar" },
    -    jarName in packageDependency <<= version map { v => "spark-assembly-" 
+ v + "-hadoop" + hadoopVersion + "-deps.jar" }
    +    jarName in packageDependency <<= version map { v => "spark-assembly-" 
+ v + "-hadoop" + hadoopVersion + "-deps.jar" } ,
    +    mergeStrategy in assembly <<= (mergeStrategy in assembly) { (old) =>
    --- End diff --
    
    We should probably just add a line to the mergeStrategy that is already 
defined a few lines below instead of creating a new one here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to