HeartSaVioR commented on code in PR #48517:
URL: https://github.com/apache/spark/pull/48517#discussion_r1809639753
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/CollectMetricsExec.scala:
##########
@@ -98,13 +99,30 @@ object CollectMetricsExec extends AdaptiveSparkPlanHelper {
/**
* Recursively collect all collected metrics from a query tree.
*/
- def collect(plan: SparkPlan): Map[String, Row] = {
- val metrics = collectWithSubqueries(plan) {
+ def collect(physicalPlan: SparkPlan, analyzedOpt: Option[LogicalPlan]):
Map[String, Row] = {
Review Comment:
Please take a look at the pattern for InMemoryTableScanExec: we may not have
logical link for the physical plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
