HyukjinKwon commented on code in PR #48580: URL: https://github.com/apache/spark/pull/48580#discussion_r1809771805
########## python/pyspark/sql/connect/functions/builtin.py: ########## @@ -617,6 +617,13 @@ def ceiling(col: "ColumnOrName", scale: Optional[Union[Column, int]] = None) -> ceiling.__doc__ = pysparkfuncs.ceiling.__doc__ +def try_conv(col: "ColumnOrName", fromBase: int, toBase: int) -> Column: Review Comment: Let's add a test at `test_functions.py` so the tests can be shared ########## python/pyspark/sql/connect/functions/builtin.py: ########## @@ -617,6 +617,13 @@ def ceiling(col: "ColumnOrName", scale: Optional[Union[Column, int]] = None) -> ceiling.__doc__ = pysparkfuncs.ceiling.__doc__ +def try_conv(col: "ColumnOrName", fromBase: int, toBase: int) -> Column: Review Comment: Let's add a test at `test_functions.py` so the tests can be shared between Spark Classic and Spark Connect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
