cloud-fan commented on code in PR #48529: URL: https://github.com/apache/spark/pull/48529#discussion_r1810791306
########## sql/core/src/test/resources/sql-tests/analyzer-results/grouping_set.sql.out: ########## @@ -159,28 +159,42 @@ Sort [-col1#x ASC NULLS FIRST], true -- !query SELECT a, b, c, count(d) FROM grouping GROUP BY WITH ROLLUP Review Comment: This case is fine as we just changed the error message. Is there a case that we actually change semantic as now we allow column alias in the GROUP BY clause? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
