vladanvasi-db commented on code in PR #48585:
URL: https://github.com/apache/spark/pull/48585#discussion_r1810881746


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CollationTypeCasts.scala:
##########
@@ -200,4 +199,15 @@ object CollationTypeCasts extends TypeCoercionRule {
         }
     }
   }
+
+  /**
+   * Returns whether the expression has explicit collated output type.
+   */
+  def hasExplicitCollation(expr: Expression): Boolean = {
+    expr match {
+      case _: Collate => true
+      case alias: Alias => hasExplicitCollation(alias.child)

Review Comment:
   I will add a test case for this with an expression that gets the subquery as 
its input in these set operators



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to