magpierre commented on code in PR #82:
URL: https://github.com/apache/spark-connect-go/pull/82#discussion_r1812410660
##########
spark/client/conf.go:
##########
@@ -0,0 +1,127 @@
+package client
+
+import (
+ "context"
+
+ proto "github.com/apache/spark-connect-go/v35/internal/generated"
+ "github.com/apache/spark-connect-go/v35/spark/client/base"
+)
+
+// Public interface RuntimeConfig
+type RuntimeConfig interface {
+ GetAll(ctx context.Context) (*map[string]string, error)
Review Comment:
I agree, it is ugly. I am used to work with pointers but it leads to ugly
user code such as (*map)["key"] which is really not bringing any value, so I
will adjust
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
