MaxGekk commented on code in PR #48612:
URL: https://github.com/apache/spark/pull/48612#discussion_r1812930139
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/percentiles.scala:
##########
@@ -133,7 +133,8 @@ abstract class PercentileBase
if (frqLong > 0) {
buffer.changeValue(key, frqLong, _ + frqLong)
} else if (frqLong < 0) {
- throw
QueryExecutionErrors.negativeValueUnexpectedError(frequencyExpression)
+ throw QueryExecutionErrors.negativeValueUnexpectedError(
+ frequencyExpression, frqLong.toString)
Review Comment:
Please, just pass a `Long`, and convert it inside of
`negativeValueUnexpectedError` properly.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##########
@@ -385,10 +385,11 @@ private[sql] object QueryExecutionErrors extends
QueryErrorsBase with ExecutionE
}
def negativeValueUnexpectedError(
- frequencyExpression : Expression): SparkIllegalArgumentException = {
+ frequencyExpression: Expression, negativeValue: String):
SparkIllegalArgumentException = {
new SparkIllegalArgumentException(
- errorClass = "_LEGACY_ERROR_TEMP_2013",
- messageParameters = Map("frequencyExpression" ->
frequencyExpression.sql))
+ errorClass = "NEGATIVE_VALUES_IN_FREQUENCY_EXPRESSION",
+ messageParameters = Map(
+ "frequencyExpression" -> frequencyExpression.sql, "negativeValue" ->
negativeValue))
Review Comment:
Use `toSQLExpr` for expressions, and `toSQLValue` for the value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
