uros-db commented on code in PR #48626:
URL: https://github.com/apache/spark/pull/48626#discussion_r1813400314
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##########
@@ -324,6 +325,11 @@ protected enum SpaceTrimming {
private static final int INDETERMINATE_COLLATION_ID = -1;
+ /**
+ * UTF8 Binary collation version.
+ */
+ private static final String UTF8_BINARY_VERSION = "1.0";
Review Comment:
so why `1.0`?
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##########
@@ -324,6 +325,11 @@ protected enum SpaceTrimming {
private static final int INDETERMINATE_COLLATION_ID = -1;
+ /**
+ * UTF8 Binary collation version.
+ */
+ private static final String UTF8_BINARY_VERSION = "1.0";
Review Comment:
this is a string field, I don't think 1.0 is a great choice... did we
consider simply "N/A"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
