MaxGekk commented on code in PR #48598:
URL: https://github.com/apache/spark/pull/48598#discussion_r1814433450
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala:
##########
@@ -655,6 +658,9 @@ case class InSet(child: Expression, hset: Set[Any]) extends
UnaryExpression with
}
@transient lazy val set: Set[Any] = child.dataType match {
+ case st: StringType if !st.isUTF8BinaryCollation =>
Review Comment:
Yep, in that case `InSet` uses `TreeSet` to which we pass an `Ordering`
instance. The last one is aware of collations via
https://github.com/apache/spark/blob/aeddc3f55e604616d683bdcc3ce7c21c95b018f6/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/PhysicalDataType.scala#L46
Let me add a few checks for nested collated strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
