siying commented on code in PR #48355:
URL: https://github.com/apache/spark/pull/48355#discussion_r1815783644
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStoreChangelog.scala:
##########
@@ -101,6 +101,13 @@ abstract class StateStoreChangelogWriter(
fm.createAtomic(file, overwriteIfPossible = true)
protected var compressedStream: DataOutputStream =
compressStream(backingFileStream)
+ def writeLineage(lineage: Array[(Long, String)]): Unit = {
+ val lineageStr = lineage.map { case (version, uniqueId) =>
+ s"$version:$uniqueId"
+ }.mkString(" ")
Review Comment:
I agree that custom format is fine, but it doesn't mean the format doesn't
matter. This is a on-disk format, so it is permanent and we have to support
forever. If we would like to come up with human readible format, why it is
something separated by space, not JSON? The space separated strings are not
robust. How if one day, someone decides that the unique ID will contain a
space, this will break.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
