HeartSaVioR commented on code in PR #48570:
URL: https://github.com/apache/spark/pull/48570#discussion_r1816016759
##########
sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -573,7 +573,8 @@ class Dataset[T] private[sql](
require(!IntervalUtils.isNegative(parsedDelay),
s"delay threshold ($delayThreshold) should not be negative.")
EliminateEventTimeWatermark(
- EventTimeWatermark(UnresolvedAttribute(eventTime), parsedDelay,
logicalPlan))
+ EventTimeWatermark(util.UUID.randomUUID(),
UnresolvedAttribute(eventTime),
Review Comment:
@dongjoon-hyun
Ah I just remembered. The file has various reference of `util.XXX` already
(I guess we tend to use jutil to differentiate with scala.util but we didn't
for this file), so if I import the class with full qualifier, it'll be diverged
with existing style in the file. Would we like to be consistent with existing
file, or across files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
