ericm-db commented on code in PR #48650:
URL: https://github.com/apache/spark/pull/48650#discussion_r1816065069
##########
connector/avro/src/main/scala/org/apache/spark/sql/avro/SchemaConverters.scala:
##########
@@ -17,365 +17,41 @@
package org.apache.spark.sql.avro
-import java.util.Locale
+import org.apache.avro.Schema
-import scala.collection.mutable
-import scala.jdk.CollectionConverters._
+import org.apache.spark.annotation.Evolving
+import org.apache.spark.sql.avro.{SchemaConverters => CoreSchemaConverters}
-import org.apache.avro.{LogicalTypes, Schema, SchemaBuilder}
-import org.apache.avro.LogicalTypes.{Date, Decimal, LocalTimestampMicros,
LocalTimestampMillis, TimestampMicros, TimestampMillis}
-import org.apache.avro.Schema.Type._
+@deprecated("Use SchemaConverters in sql/core instead", "4.0.0")
+@Evolving
+object SchemaConverters {
Review Comment:
@gengliangwang I know you wanted to keep a deprecated file with the same
name here, but it conflicts with the SchemaConverters file we have moved to
sql/core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
