Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/6567#discussion_r31561598
--- Diff: dev/create-release/create-release.sh ---
@@ -228,14 +228,14 @@ if [[ ! "$@" =~ --skip-package ]]; then
# We increment the Zinc port each time to avoid OOM's and other
craziness if multiple builds
# share the same Zinc server.
- make_binary_release "hadoop1" "-Psparkr -Phadoop-1 -Phive
-Phive-thriftserver" "3030" &
- make_binary_release "hadoop1-scala2.11" "-Psparkr -Phadoop-1 -Phive
-Dscala-2.11" "3031" &
- make_binary_release "cdh4" "-Psparkr -Phadoop-1 -Phive
-Phive-thriftserver -Dhadoop.version=2.0.0-mr1-cdh4.2.0" "3032" &
- make_binary_release "hadoop2.3" "-Psparkr -Phadoop-2.3 -Phive
-Phive-thriftserver -Pyarn" "3033" &
- make_binary_release "hadoop2.4" "-Psparkr -Phadoop-2.4 -Phive
-Phive-thriftserver -Pyarn" "3034" &
- make_binary_release "mapr3" "-Pmapr3 -Psparkr -Phive
-Phive-thriftserver" "3035" &
- make_binary_release "mapr4" "-Pmapr4 -Psparkr -Pyarn -Phive
-Phive-thriftserver" "3036" &
- make_binary_release "hadoop2.4-without-hive" "-Psparkr -Phadoop-2.4
-Pyarn" "3037" &
+ make_binary_release "hadoop1" "-Psparkr -Psparkr-docs -Phadoop-1 -Phive
-Phive-thriftserver" "3030" &
--- End diff --
Personally I don't mind if this is kept behind a flag, because most
developers won't necessarily want to install a bunch of extra packages to just
try and get SparkR building. We could just merge it under the sparkr profile if
we want though, it's not a huge concern.
One other note, I've been prototyping a refactoring of these build scripts
locally that I plan to contribute back after the 1.4 release. So any changes
should be made there too:
https://github.com/pwendell/spark-utils/tree/master/new-release-scripts
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
