panbingkun commented on code in PR #48653:
URL: https://github.com/apache/spark/pull/48653#discussion_r1816963974
##########
sql/core/src/test/scala/org/apache/spark/sql/CsvFunctionsSuite.scala:
##########
@@ -485,7 +486,7 @@ class CsvFunctionsSuite extends QueryTest with
SharedSparkSession {
test("SPARK-32968: bad csv input with csv pruning optimization") {
Seq("true", "false").foreach { enabled =>
withSQLConf(SQLConf.CSV_EXPRESSION_OPTIMIZATION.key -> enabled) {
- val df =
sparkContext.parallelize(Seq("1,\u0001\u0000\u0001234")).toDF("csv")
+ val df =
sparkContext.parallelize(Seq("1,\u0001\u0000\u0001234X")).toDF("csv")
Review Comment:
I think the purpose of case `SPARK-32968: bad csv input with csv pruning
optimization` is to test for illegal characters causing parse `exceptions`.
After this PR, it should be able to parse `correctly` (from `exception` to
`normal`, it should not belong to `break changes`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
