HeartSaVioR commented on code in PR #48676:
URL: https://github.com/apache/spark/pull/48676#discussion_r1818483744
##########
sql/core/src/test/scala/org/apache/spark/sql/streaming/TriggerAvailableNowSuite.scala:
##########
@@ -170,10 +173,16 @@ class TriggerAvailableNowSuite extends
FileStreamSourceTest {
val q = startQuery()
+ val expectedNumBatches = if (!useWrapper &&
!supportTriggerAvailableNow) {
+ // Spark will decide to fall back to SingleBatchExecutor.
+ 1
+ } else {
+ 3
+ }
+
try {
assert(q.awaitTermination(streamingTimeout.toMillis))
- // only one batch has data in both sources, thus counted, see
SPARK-24050
Review Comment:
This change of test represents that this PR fixes the limitation.
##########
sql/core/src/test/scala/org/apache/spark/sql/streaming/TriggerAvailableNowSuite.scala:
##########
@@ -193,8 +202,7 @@ class TriggerAvailableNowSuite extends FileStreamSourceTest
{
val q2 = startQuery()
try {
assert(q2.awaitTermination(streamingTimeout.toMillis))
- // only one batch has data in both sources, thus counted, see
SPARK-24050
Review Comment:
Here as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
