Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/5400#issuecomment-108090342
The latest update seems ok to me after a cursory check of the things I
commented on. I'm still a little bit concerned about the tests being slow, but
it's not like our test suite isn't already ridiculously slow. Maybe you should
revive that test tags patch of yours, @squito.
@JoshRosen IIUC the purpose of the large file test would be to test the
actual mmap code, so using a checksumming stream doesn't seem to me like it
would help much (since you still would need to create the file and read it back
through the large buffer API).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
