Angryrou commented on code in PR #48649: URL: https://github.com/apache/spark/pull/48649#discussion_r1820017432
########## sql/core/src/test/resources/sql-tests/inputs/pipe-operators.sql: ########## @@ -665,15 +665,28 @@ table t table t |> order by x sort by x; --- The WINDOW clause is not supported yet. +-- The WINDOW clause: positive tests. +------------------------------------- table windowTestData -|> window w as (partition by cte order by val) +|> window w as (partition by cate order by val) |> select cate, sum(val) over w; +table windowTestData +|> window w1 as (partition by cate), w2 as (partition by val order by cate) +|> select sum(val) over w1, first_value(cate) over w2; Review Comment: > |> window ... creating window names that shadow other valid column names. Is this allowed? It is allowed in the current SQL syntax (see the pic). Do you know if this is expected? If not, we may need a separate issue to fix this.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
