cloud-fan commented on code in PR #48679:
URL: https://github.com/apache/spark/pull/48679#discussion_r1820899323
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala:
##########
@@ -310,6 +310,21 @@ case class StaticInvoke(
val (argCode, argString, resultIsNull) = prepareArguments(ctx)
+ val needTryCatch = method.getExceptionTypes.nonEmpty
+
+ def getFuncResult(resultVal: String, castType: String, callFunc: String):
String =
Review Comment:
shall we move more common code to `InvokeLike`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
