micheal-o commented on code in PR #48685:
URL: https://github.com/apache/spark/pull/48685#discussion_r1826915210
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala:
##########
@@ -291,6 +291,8 @@ class RocksDB(
acquire(LoadStore)
recordedMetrics = None
logInfo(log"Loading ${MDC(LogKeys.VERSION_NUM, version)}")
+ // Updating the current version, so the mapping can correctly identify
reusable files.
+ rocksDBFileMapping.currentVersion = version
Review Comment:
@HeartSaVioR I understand your confusion. This `currentVersion` field in the
mapping was something I didn't like and wanted to remove in the original code,
but left it for another time since I had already done a lot of refactoring in
that PR.
Please take a look at the code now, I have removed the use of
`currentVersion` field. It wasn't meant to track the db loaded version. The
code should be clearer now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
