mihailotim-db commented on code in PR #48753:
URL: https://github.com/apache/spark/pull/48753#discussion_r1828170179
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ApplyCharTypePadding.scala:
##########
@@ -39,14 +36,6 @@ import org.apache.spark.unsafe.types.UTF8String
*/
object ApplyCharTypePadding extends Rule[LogicalPlan] {
- object AttrOrOuterRef {
- def unapply(e: Expression): Option[Attribute] = e match {
- case a: Attribute => Some(a)
- case OuterReference(a: Attribute) => Some(a)
- case _ => None
- }
- }
-
override def apply(plan: LogicalPlan): LogicalPlan = {
Review Comment:
Didn't refactor `apply` method since it needs to import `LogicalRelation`
from `core` package. This will probably be handled like an extension in the
single-pass framework
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
