LuciferYang commented on code in PR #48757: URL: https://github.com/apache/spark/pull/48757#discussion_r1828774820
########## dev/stream-state-gen-protos.sh: ########## @@ -0,0 +1,98 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +set -ex + +if [[ $# -gt 0 ]]; then Review Comment: I have written a script with reference to https://github.com/apache/spark/blob/master/dev/connect-gen-protos.sh , whose main function is to use buf to generate corresponding `_pb2.py` and `_pb2.pyi` files from `.proto` files in the `sql/core/src/main/protobuf/` directory. Currently, the OUTPUT_PATH is fixed to `${SPARK_HOME}/python/pyspark/sql/streaming/proto`. If there are more complex requirements in the future, this script will need to be further enhanced. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
