dongjoon-hyun commented on code in PR #48755:
URL: https://github.com/apache/spark/pull/48755#discussion_r1829535732


##########
sql/core/src/test/scala/org/apache/spark/sql/SparkSessionBuilderSuite.scala:
##########
@@ -589,4 +589,13 @@ class SparkSessionBuilderSuite extends SparkFunSuite with 
Eventually {
       assert(session.conf.get(e._1) == e._2.toString)
     }
   }
+
+  test("SPARK-50222: Support spark.submit.appName") {
+    val session = SparkSession.builder()

Review Comment:
   To @LuciferYang , you are saying that the following.
   
   ```
   val session = SparkSession.builder()
         .master("local")
         .appName("appName")
         .config("spark.app.name", "newAppName")
   ```
   
   This PR description aims to handle the following static code by setting `-c 
spark.submit.appName=newAppName` outside without a code change. Please try to 
change Apache Spark `SparkPi` example. Then, you can see that why you cannot 
override.
   ```
   val session = SparkSession.builder()
         .master("local")
         .appName("appName")
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to