viirya commented on code in PR #48767:
URL: https://github.com/apache/spark/pull/48767#discussion_r1830072331
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/Columnar.scala:
##########
@@ -194,9 +194,14 @@ case class ColumnarToRowExec(child: SparkPlan) extends
ColumnarToRowTransition w
| $shouldStop
| }
| $idx = $numRows;
+ | $batch.closeIfNotWritable();
| $batch = null;
| $nextBatchFuncName();
|}
+ |// clean up resources
+ |if ($batch != null) {
+ | $batch.close();
+ |}
Review Comment:
This looks like memory leak for off-heap case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
