yaooqinn commented on code in PR #48772:
URL: https://github.com/apache/spark/pull/48772#discussion_r1831345147
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala:
##########
@@ -322,7 +322,8 @@ case class StaticInvoke(
propagateNull: Boolean = true,
returnNullable: Boolean = true,
isDeterministic: Boolean = true,
- scalarFunction: Option[ScalarFunction[_]] = None) extends InvokeLike {
+ scalarFunction: Option[ScalarFunction[_]] = None,
+ override val nullIntolerant: Boolean = false) extends InvokeLike {
Review Comment:
I guess they are the same too. If you don't mind， I'd like too keep the PR
in AS-IS state to minimize the potential influence of this refactoring work.
Since nullIntolerant defaults to false，propagateNull defaults true，mapping them
blindly might result in many unsure plan changes，I‘d like to revist and revise
them in followups in the meanwhile I'm fixing the RuntimeReplaceables which use
StaticInvoke and Invoke heavily？ WDYT？ @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
