uros-db commented on code in PR #48774:
URL: https://github.com/apache/spark/pull/48774#discussion_r1832354632
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##########
@@ -1598,11 +1598,38 @@ class CollationSuite extends DatasourceV2SQLBase with
AdaptiveSparkPlanHelper {
case b: HashJoin => b.leftKeys.head
}.head.isInstanceOf[CollationKey])
}
+
+ // Disable broadcast join to force sort merge join.
+ withSQLConf(SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "-1") {
Review Comment:
how about smth like this
```
Seq("-1", "1").foreach(val =>
withSQLConf(SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> val) {
...
```
i.e. iterating over possible vals, to reduce duplication
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
