MaxGekk commented on code in PR #48332:
URL: https://github.com/apache/spark/pull/48332#discussion_r1835483214
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala:
##########
@@ -436,9 +436,8 @@ class DateExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper {
withSQLConf((SQLConf.ANSI_ENABLED.key, "true")) {
checkErrorInExpression[SparkIllegalArgumentException](
DateAddInterval(Literal(d), Literal(new CalendarInterval(1, 1, 25 *
MICROS_PER_HOUR))),
- "_LEGACY_ERROR_TEMP_2000",
- Map("message" ->
- "Cannot add hours, minutes or seconds, milliseconds, microseconds to
a date",
+ "INVALID_PARAMETER_VALUE.INTERVAL_WITH_MICROSECONDS",
+ Map("parameter" -> "`interval`", "functionName" -> "`dateaddinterval`",
Review Comment:
`dateaddinterval ` there is no such function. That might confuse users. We
could pass `+` instead, or create a error condition especially for the
`DateAddInterval` expression (not sub-class of `INVALID_PARAMETER_VALUE `).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
