cloud-fan commented on code in PR #48779: URL: https://github.com/apache/spark/pull/48779#discussion_r1835879016
########## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/SparkShreddingUtils.scala: ########## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.execution.datasources.parquet + +import org.apache.spark.sql.catalyst.InternalRow +import org.apache.spark.sql.catalyst.expressions._ +import org.apache.spark.sql.catalyst.util.GenericArrayData +import org.apache.spark.sql.errors.QueryCompilationErrors +import org.apache.spark.sql.types._ +import org.apache.spark.types.variant._ +import org.apache.spark.unsafe.types._ + +case object SparkShreddingUtils { + def buildVariantSchema(schema: DataType): VariantSchema = { + schema match { + case s: StructType => buildVariantSchema(s, topLevel = true) + case _ => throw QueryCompilationErrors.invalidVariantSchema(schema) + } + } + + /** + * Given an expected schema of a Variant value, returns a suitable schema for shredding, by + * inserting appropriate intermediate value/typed_value fields at each level. + * For example, to represent the JSON {"a": 1, "b": "hello"}, + * the schema struct<a: int, b: string> could be passed into this function, and it would return + * the shredding scheme: + * struct< + * metadata: binary, + * value: binary, Review Comment: is the value duplicated? In addition to the typed_value, we also store the raw value for each typed field, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
