mikhailnik-db commented on code in PR #48748:
URL: https://github.com/apache/spark/pull/48748#discussion_r1840840176
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -2216,21 +2216,25 @@ class Analyzer(override val catalogManager:
CatalogManager) extends RuleExecutor
numArgs: Int,
u: UnresolvedFunction): Expression = {
func match {
- case owg: SupportsOrderingWithinGroup if u.isDistinct =>
+ case owg: InverseDistributionFunction if u.isDistinct =>
Review Comment:
I don't know, but I think it's banned because the `percentile_cont(DISTINCT
0.5) WITHIN GROUP (ORDER BY v)` syntax seems incorrect. Without this `case` it
will calculate 0.5 percentile over distinct `v` but IMO, it's confusing. I
would rather expect `percentile_cont(0.5) WITHIN GROUP (ORDER BY DISTINCT v)`
syntax for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
