yaooqinn commented on code in PR #48772:
URL: https://github.com/apache/spark/pull/48772#discussion_r1841462535
##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala:
##########
@@ -1633,15 +1633,15 @@ class JDBCV2Suite extends QueryTest with
SharedSparkSession with ExplainSuiteHel
checkAnswer(df4, Seq(Row(6, "jen", 12000, 1200, true)))
val df5 = sql("SELECT name FROM h2.test.employee WHERE " +
- "aes_encrypt(cast(null as string), name) is null")
+ "aes_encrypt(name, '1234567812345678') != 'spark'")
checkFiltersRemoved(df5, false)
- val expectedPlanFragment5 = "PushedFilters: [], "
+ val expectedPlanFragment5 = "PushedFilters: [NAME IS NOT NULL], "
checkPushedInfo(df5, expectedPlanFragment5)
checkAnswer(df5, Seq(Row("amy"), Row("cathy"), Row("alex"), Row("david"),
Row("jen")))
val df6 = sql("SELECT name FROM h2.test.employee WHERE " +
"aes_decrypt(cast(null as binary), name) is null")
Review Comment:
I haven't done a full check, but I believe some parameter checks may occur
in the original expressions, while others might be checked in the replacement,
which could result in different behaviors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
