cloud-fan commented on code in PR #48844:
URL: https://github.com/apache/spark/pull/48844#discussion_r1842102796
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ddl.scala:
##########
@@ -43,7 +43,7 @@ import org.apache.spark.sql.types._
case class CreateTable(
tableDesc: CatalogTable,
mode: SaveMode,
- query: Option[LogicalPlan]) extends LogicalPlan {
+ query: Option[LogicalPlan]) extends LogicalPlan with V1DDLCommand {
Review Comment:
I don't think this works. We need to resolve string collation in
`tableDesc.schema`, and the rule must match `CreateTable` directly to do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
