mikhailnik-db commented on code in PR #48748:
URL: https://github.com/apache/spark/pull/48748#discussion_r1842609305
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -2216,21 +2216,25 @@ class Analyzer(override val catalogManager:
CatalogManager) extends RuleExecutor
numArgs: Int,
u: UnresolvedFunction): Expression = {
func match {
- case owg: SupportsOrderingWithinGroup if u.isDistinct =>
+ case owg: InverseDistributionFunction if u.isDistinct =>
throw
QueryCompilationErrors.distinctInverseDistributionFunctionUnsupportedError(
owg.prettyName)
- case owg: SupportsOrderingWithinGroup
+ case owg: InverseDistributionFunction
if !owg.orderingFilled && u.orderingWithinGroup.isEmpty =>
Review Comment:
Removed `InverseDistributionFunction` and renamed
`INVALID_INVERSE_DISTRIBUTION_FUNCTION` -> `INVALID_WITHIN_GROUP_EXPRESSION`.
Refactored messages a little so it will be clearer that the error is related
only to one specific function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
