zhengruifeng commented on code in PR #48856:
URL: https://github.com/apache/spark/pull/48856#discussion_r1844867144
##########
python/pyspark/sql/connect/session.py:
##########
@@ -706,9 +724,9 @@ def createDataFrame(
else:
local_relation = LocalRelation(_table)
- cache_threshold =
self._client.get_configs("spark.sql.session.localRelationCacheThreshold")
+ cache_threshold =
conf_getter["spark.sql.session.localRelationCacheThreshold"]
Review Comment:
there are 2 cases that we don't need the configs:
1, the local data is empty, and the schema is specified, it returns a valid
empty df;
2, the creation fails due to some assertions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
