neilramaswamy commented on code in PR #48853:
URL: https://github.com/apache/spark/pull/48853#discussion_r1847436733
##########
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithMapStateTTLSuite.scala:
##########
@@ -83,6 +83,8 @@ class MapStateSingleKeyTTLProcessor(ttlConfig: TTLConfig)
ttlValues.foreach { v =>
results = OutputEvent(key, -1, isTTLValue = true, ttlValue = v._2) ::
results
}
+ } else if (row.action == "clear") {
Review Comment:
Before my changes, the `clear()` logic was broken; when a user called clear,
_all_ their TTL state would have been removed. I added this hear so that we
have coverage over `clear`.
##########
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithValueStateTTLSuite.scala:
##########
@@ -59,6 +59,8 @@ object TTLInputProcessFunction {
ttlValues.foreach { v =>
results = OutputEvent(key, -1, isTTLValue = true, ttlValue = v) ::
results
}
+ } else if (row.action == "clear") {
Review Comment:
Same as earlier comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
