cloud-fan commented on code in PR #48879:
URL: https://github.com/apache/spark/pull/48879#discussion_r1848291348
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingParserSuite.scala:
##########
@@ -20,35 +20,39 @@ package org.apache.spark.sql.catalyst.parser
import org.apache.spark.SparkFunSuite
import org.apache.spark.sql.catalyst.expressions.{Alias, EqualTo, Expression,
In, Literal, ScalarSubquery}
import org.apache.spark.sql.catalyst.plans.SQLHelper
-import org.apache.spark.sql.catalyst.plans.logical.{CreateVariable, Project}
+import org.apache.spark.sql.catalyst.plans.logical.{CaseStatement,
CompoundBody, CreateVariable, IfElseStatement, IterateStatement,
LeaveStatement, LoopStatement, Project, RepeatStatement, SingleStatement,
WhileStatement}
import org.apache.spark.sql.errors.DataTypeErrors.toSQLId
import org.apache.spark.sql.exceptions.SqlScriptingException
+import org.apache.spark.sql.internal.SQLConf
class SqlScriptingParserSuite extends SparkFunSuite with SQLHelper {
import CatalystSqlParser._
- test("single select") {
- val sqlScriptText = "SELECT 1;"
- val tree = parseScript(sqlScriptText)
- assert(tree.collection.length == 1)
- assert(tree.collection.head.isInstanceOf[SingleStatement])
- val sparkStatement = tree.collection.head.asInstanceOf[SingleStatement]
- assert(sparkStatement.getText == "SELECT 1;")
+ // Tests setup
+ private var originalSqlScriptingConfVal: String = _
Review Comment:
This var is not accessed, seems we can remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
