HeartSaVioR commented on code in PR #48838:
URL: https://github.com/apache/spark/pull/48838#discussion_r1849549495
##########
python/pyspark/sql/pandas/group_ops.py:
##########
@@ -573,7 +579,11 @@ def transformWithStateUDF(
statefulProcessorApiClient.set_handle_state(StatefulProcessorHandleState.CLOSED)
return iter([])
- result = handle_data_with_timers(statefulProcessorApiClient, key,
inputRows)
+ batch_timestamp, watermark_timestamp =
get_timestamps(statefulProcessorApiClient)
Review Comment:
Ideally this shouldn't be called at every key. If we split out the handling
of timer expiration from the handling of input rows, we would only need to call
this at once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
