EnricoMi commented on code in PR #39754:
URL: https://github.com/apache/spark/pull/39754#discussion_r1854014296


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ColumnResolutionHelper.scala:
##########
@@ -196,6 +196,8 @@ trait ColumnResolutionHelper extends Logging with 
DataTypeErrorsBase {
             u.copy(child = newChild)
           }
 
+        case s : ScopedExpression => s.mapScope(innerResolve(_, isTopLevel = 
false))

Review Comment:
   Using `resolveColumnByName` here might not be generic enough to support all 
kinds of expressions. I like the recursive call here, as it simply mimics the 
`mapChildren` call below but with the scope only.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to