dongjoon-hyun commented on code in PR #48939:
URL: https://github.com/apache/spark/pull/48939#discussion_r1854865193
##########
sbin/start-worker.sh:
##########
@@ -47,7 +47,7 @@ if [[ $# -lt 1 ]] || [[ "$@" = *--help ]] || [[ "$@" = *-h
]]; then
pattern+="\|Registered signal handler for"
"${SPARK_HOME}"/bin/spark-class $CLASS --help 2>&1 | grep -v "$pattern" 1>&2
- exit 1
+ [[ $# -lt 1 ]] && exit 1 || exit 0
Review Comment:
Note that,
- `sbin/start-worker.sh` with no argument exits with `1` in the same way.
- `sbin/start-worker.sh --help` exists with `0` after this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
