bersprockets commented on code in PR #48627:
URL: https://github.com/apache/spark/pull/48627#discussion_r1855538615
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala:
##########
@@ -245,6 +266,55 @@ object RewritePredicateSubquery extends Rule[LogicalPlan]
with PredicateHelper {
condition = Some(newCondition)))
}
}
+ case a: Aggregate if
exprsContainsAggregateInSubquery(a.aggregateExpressions) =>
Review Comment:
@dtenedor
I could move the entire new handler into a helper function in another file.
On the other hand, this file contains 6 rules, all related to subqueries in
one way or another. They could be split up (in a separate refactor, not by this
PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
