soumasish commented on code in PR #48941:
URL: https://github.com/apache/spark/pull/48941#discussion_r1856788029
##########
launcher/src/main/java/org/apache/spark/launcher/SparkSubmitCommandBuilder.java:
##########
@@ -339,6 +339,16 @@ private void checkJavaOptions(String javaOptions) {
}
}
+ private String sanitizeConfValue(String value) {
+ if (value != null) {
+ String[] unsafeChars = {"`", "$(", ")", ";", "&", "|", "<", ">", "*",
"?"};
Review Comment:
@HyukjinKwon Thank you for your feedback! I've added references and comments
to justify the specification of the unsafe characters in the sanitizeConfValue
method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
