HeartSaVioR commented on code in PR #48124:
URL: https://github.com/apache/spark/pull/48124#discussion_r1857611909
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala:
##########
@@ -44,6 +44,9 @@ object UnsupportedOperationChecker extends Logging {
throwError("dropDuplicatesWithinWatermark is not supported with batch
" +
"DataFrames/DataSets")(d)
+ case t: TransformWithStateInPandas =>
Review Comment:
Let's file a JIRA ticket with TODO like this.
```
// TODO(SPARK-40443): support applyInPandasWithState in batch query
throw new
SparkUnsupportedOperationException("_LEGACY_ERROR_TEMP_3176")
```
I see my inconsistency here - the above is in BasicOperators in
SparkStrategies.
https://github.com/apache/spark/blob/f7122137006e941393c8be619fb51b3b713a24cb/sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala#L966-L968
Shall we move this to BasicOperators with adding TODO comment like the
above? Let's leave this place to be something there is a reason not to support
and won't support in future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
