neilramaswamy commented on PR #48853: URL: https://github.com/apache/spark/pull/48853#issuecomment-2499671467
Thanks for the detailed review, @HeartSaVioR. I have reacted with 👍 for comments that I have addressed, and I will let you resolve the conversation if you think it's sufficient. To summarize where we are: - I'm not sure whether we want some of the internal-only `TTLState` members/methods to be `protected` or `private[sql]`. I think they should be `private[sql]` so that we can use in testing, but not available to users. - I think that `TTLState` might be confusing because it's not acting fully as a mix-in, but rather a bunch of TTL utilities. Maybe I can make it an abstract class, and rename it to `TTLUtils`? In my most recent revisions, I have also tried to make the comments less verbose and not provide content better suited for a design doc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
