cloud-fan commented on code in PR #48509:
URL: https://github.com/apache/spark/pull/48509#discussion_r1858515472
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizeJsonExprsSuite.scala:
##########
@@ -292,7 +292,7 @@ class OptimizeJsonExprsSuite extends PlanTest with
ExpressionEvalHelper {
Seq("""{"a":1, "b":2, "c": 123, "d": "test"}""", null).foreach(v => {
val row = create_row(v)
- checkEvaluation(e1, e2.eval(row), row)
+ checkEvaluation(e1, replace(e2).eval(row), row)
Review Comment:
I missed this. `JsonToStructs` needs to carry the semantic information so
that the optimizer rule can match it and do something. Replacing it with
`Invoke` breaks it.
I propose to revert it and revisit other PRs that reimplement expressions
with `RuntimeReplaceable`.
cc @panbingkun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
