nija-at commented on code in PR #48802: URL: https://github.com/apache/spark/pull/48802#discussion_r1858577670
########## python/pyspark/sql/connect/logging.py: ########## @@ -21,30 +21,35 @@ import os from typing import Optional -__all__ = [ - "getLogLevel", -] +__all__ = ["configure_logging", "getLogLevel"] -def _configure_logging() -> logging.Logger: - """Configure logging for the Spark Connect clients.""" +def configure_logging(level: Optional[str] = None) -> logging.Logger: Review Comment: Good call. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
