cloud-fan commented on code in PR #48962:
URL: https://github.com/apache/spark/pull/48962#discussion_r1860114012


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ResolveInlineTablesSuite.scala:
##########
@@ -117,8 +117,9 @@ class ResolveInlineTablesSuite extends AnalysisTest with 
BeforeAndAfter {
     val table = UnresolvedInlineTable(Seq("c1"),
       Seq(Seq(Cast(lit("1991-12-06 00:00:00.0"), TimestampType))))
     val withTimeZone = ResolveTimeZone.apply(table)
+    val resolvedStringTypes = ResolveDefaultStringTypes.apply(withTimeZone)

Review Comment:
   why do we need this change? It's not under DML command and the session 
collation is not set, so the optimization should be triggered.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to