yaooqinn commented on code in PR #48986:
URL: https://github.com/apache/spark/pull/48986#discussion_r1860404897
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala:
##########
@@ -1130,10 +1133,6 @@ private[hive] object HiveClientImpl extends Logging {
Option(hc.getComment).map(field.withComment).getOrElse(field)
}
- private def verifyColumnDataType(schema: StructType): Unit = {
Review Comment:
This is a misleading step for the write path, the `schema` here is both
produced and verified by Spark itself but reports a CANNOT_RECOGNIZE_HIVE_TYPE
error to us.
Also, the Hive Metastore and Spark parser handle the backtick (`) character
in opposite ways. It's tricky to rely on the spark parser to verify hive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
