cloud-fan commented on code in PR #48897:
URL: https://github.com/apache/spark/pull/48897#discussion_r1861453157
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/PostgresNamespaceSuite.scala:
##########
@@ -26,16 +26,16 @@ import org.apache.spark.sql.util.CaseInsensitiveStringMap
import org.apache.spark.tags.DockerTest
/**
- * To run this test suite for a specific version (e.g., postgres:17.0-alpine):
+ * To run this test suite for a specific version (e.g., postgres:17.1-alpine):
* {{{
- * ENABLE_DOCKER_INTEGRATION_TESTS=1
POSTGRES_DOCKER_IMAGE_NAME=postgres:17.0-alpine
+ * ENABLE_DOCKER_INTEGRATION_TESTS=1
POSTGRES_DOCKER_IMAGE_NAME=postgres:17.1-alpine
* ./build/sbt -Pdocker-integration-tests "testOnly
*v2.PostgresNamespaceSuite"
* }}}
*/
@DockerTest
class PostgresNamespaceSuite extends DockerJDBCIntegrationSuite with
V2JDBCNamespaceTest {
override val db = new DatabaseOnDocker {
- override val imageName = sys.env.getOrElse("POSTGRES_DOCKER_IMAGE_NAME",
"postgres:17.0-alpine")
+ override val imageName = sys.env.getOrElse("POSTGRES_DOCKER_IMAGE_NAME",
"postgres:17.1-alpine")
Review Comment:
shall we have a base trait to define the pgsql version in the docker test?
so that we don't need to touch so many files when we need to upgrade again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
