uros-db commented on code in PR #48739: URL: https://github.com/apache/spark/pull/48739#discussion_r1862388731
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala: ########## @@ -582,7 +582,10 @@ case class StringToMap(text: Expression, pairDelim: Expression, keyValueDelim: E override def third: Expression = keyValueDelim override def inputTypes: Seq[AbstractDataType] = - Seq(StringTypeNonCSAICollation, StringTypeNonCSAICollation, StringTypeNonCSAICollation) + Seq( + StringTypeNonCSAICollation, + StringTypeNonCSAICollation, + StringTypeNonCSAICollation) Review Comment: these changes don't really do anything? I figure that this is intentional, due to the `StringToMap` expression behaviour (which is generally collation-aware), but in that case please undo the changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
